🎨 feat: Reusable ethereum-wallet-mock package
#1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matstyler
changed the title
ethereum-wallet-mock package
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| */ | ||
| readonly page: Page | ||
| ) { | ||
| constructor(readonly page: Page) { |
Check warning
Code scanning / CodeQL
Useless assignment to property Warning
Graphite Automations"Assign drptbl as reviewer" took an action on this PR • (04/18/24)1 assignee was added to this PR based on 's automation. "Post a GIF when PR approved" took an action on this PR • (04/21/24)1 gif was posted to this PR based on 's automation. |
matstyler
changed the title
ethereum-wallet-mock packageethereum-wallet-mock package
drptbl
approved these changes
Apr 21, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Updated the Test Dapp to use Ethereum Wallet Mock instead of MetaMask.
What changed?
How to test?
Why make this change?
To provide better support for Ethereum wallets and improve testing capabilities in the Test Dapp
Motivation and context
Replaced
metamask-mockpackage by generalethereum-wallet-mock.Does it fix any issue?
#(issue)
Quality checklist